[codex] Add task check toggle command - #91
Open
bendsp wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CodeMirror editor command to toggle the checked state of Markdown task items, wires it into the renderer command system, and exposes it in the editor context menu. Unit tests cover checked, unchecked, and non-task fallthrough behavior.
Changes:
- Implement
toggleTaskCheckCommandto toggle- [ ]↔- [x]across selected lines. - Register the new command in the command registry and add a context menu entry to invoke it.
- Add unit tests validating checked/unchecked toggling and fallthrough when no task items are selected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/controllerShortcuts.test.ts | Adds unit tests for toggling task check state and fallthrough behavior. |
| src/renderer/editor/codemirror/commands.ts | Implements toggleTaskCheckCommand to toggle Markdown task checkbox markers. |
| src/renderer/components/EditorContextMenu.tsx | Adds a context menu item to trigger the new toggle task check command. |
| src/renderer/commands/commandSystem.ts | Registers the new command id and maps it to the CodeMirror command implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+372
to
+377
| { | ||
| id: "insert.toggleTaskCheck", | ||
| title: "Toggle task check", | ||
| category: "Insert", | ||
| description: "Toggle checked state for task checklist items.", | ||
| requiresEditor: true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation